Skip to content

fix(cli): skip basepath-aware flag for preview docs generation#12341

Closed
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin/1771012492-skip-basepath-aware-preview
Closed

fix(cli): skip basepath-aware flag for preview docs generation#12341
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin/1771012492-skip-basepath-aware-preview

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

Description

Refs: Related to fern-platform#7101

Preview docs deployments don't have the infrastructure for basepath-aware routing (e.g., no Upstash Redis env vars for basepath route lookups). The finishDocsRegister call was unconditionally sending basepathAware: true for both preview and production registrations, even though the startDocsPreviewRegister path already omits it.

Changes Made

  • Added !preview guard to the basepathAware spread in finishDocsRegister so it's only sent for non-preview registrations — consistent with how startDocsRegister vs startDocsPreviewRegister already handle it
  • Added CLI versions.yml entry (3.78.1)

Human Review Checklist

  • Confirm that preview deployments should never use basepath-aware routing (this is the core assumption)
  • Verify the startDocsPreviewRegister call (line ~182) also does not send basepathAware — the fix makes finishDocsRegister consistent with this

Testing

  • No unit tests added — single-line conditional change
  • Verified by code inspection that the preview path (startDocsPreviewRegister) already omits basepathAware, so finishDocsRegister should too

Link to Devin run: https://app.devin.ai/sessions/f358be06148940ee981ef3cd4ba77cb4
Requested by: kenny@buildwithfern.com

Co-Authored-By: kenny@buildwithfern.com <kenny@buildwithfern.com>
@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions
Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 25 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions Bot added the Stale This PR hasn't has any commits or comments in 25 days or more. label Mar 11, 2026
@github-actions
Copy link
Copy Markdown
Contributor

This PR was closed because it has been inactive for 5 days after being marked stale.

@github-actions github-actions Bot closed this Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stale This PR hasn't has any commits or comments in 25 days or more.

Development

Successfully merging this pull request may close these issues.

0 participants