fix(cli): skip basepath-aware flag for preview docs generation#12341
Closed
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Closed
fix(cli): skip basepath-aware flag for preview docs generation#12341devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Co-Authored-By: kenny@buildwithfern.com <kenny@buildwithfern.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
|
This PR is stale because it has been open 25 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Contributor
|
This PR was closed because it has been inactive for 5 days after being marked stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refs: Related to fern-platform#7101
Preview docs deployments don't have the infrastructure for basepath-aware routing (e.g., no Upstash Redis env vars for basepath route lookups). The
finishDocsRegistercall was unconditionally sendingbasepathAware: truefor both preview and production registrations, even though thestartDocsPreviewRegisterpath already omits it.Changes Made
!previewguard to thebasepathAwarespread infinishDocsRegisterso it's only sent for non-preview registrations — consistent with howstartDocsRegistervsstartDocsPreviewRegisteralready handle itHuman Review Checklist
startDocsPreviewRegistercall (line ~182) also does not sendbasepathAware— the fix makesfinishDocsRegisterconsistent with thisTesting
startDocsPreviewRegister) already omitsbasepathAware, sofinishDocsRegistershould tooLink to Devin run: https://app.devin.ai/sessions/f358be06148940ee981ef3cd4ba77cb4
Requested by: kenny@buildwithfern.com