Skip to content

chore(deps): bump vite-plus to pkg-pr-new pr-1588 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fengmk2 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore(deps): bump vite-plus to pkg-pr-new pr-1588 #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8427bd7
chore(deps): bump vite-plus to pkg-pr-new pr-1588
fengmk2 May 28, 2026
f18a2cf
chore(deps): refresh lockfile after vite-plus pkg-pr-new pr-1588 bump
fengmk2 May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,13 @@
"oxc-parser": "^0.126.0",
"prettier": "^3.8.3",
"typescript": "^6.0.3",
"vite-plus": "^0.1.18",
"vitest": "^4.1.4"
"vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1588",
"vitest": "^4.1.5"
},
"resolutions": {
"vite": "npm:@voidzero-dev/vite-plus-core@latest",
"vitest": "npm:@voidzero-dev/vite-plus-test@latest"
"@voidzero-dev/vite-plus-core": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@5577b0154f33d1480a3c96347e94fa5d2094de2e",
"@voidzero-dev/vite-plus-prompts": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-prompts@5577b0154f33d1480a3c96347e94fa5d2094de2e"
Comment on lines +46 to +47
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There is a version consistency issue between vite-plus and its subpackages. vite-plus is configured to use the PR branch version (@1588), while @voidzero-dev/vite-plus-core and @voidzero-dev/vite-plus-prompts are pinned to a specific commit hash (@5577b0154f33d1480a3c96347e94fa5d2094de2e). If new commits are pushed to PR 1588, vite-plus will be updated but the subpackages will remain pinned, potentially causing runtime mismatches.

Additionally, the resolution for "vite" on line 45 is still pointing to npm:@voidzero-dev/vite-plus-core@latest. This means any package depending on vite will bypass the PR 1588 build and use the latest published npm version instead. To ensure the PR build is used consistently, you should also update line 45 to point to the PR build:

    "vite": "npm:@voidzero-dev/vite-plus-core@https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1588",
Suggested change
"@voidzero-dev/vite-plus-core": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@5577b0154f33d1480a3c96347e94fa5d2094de2e",
"@voidzero-dev/vite-plus-prompts": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-prompts@5577b0154f33d1480a3c96347e94fa5d2094de2e"
"@voidzero-dev/vite-plus-core": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1588",
"@voidzero-dev/vite-plus-prompts": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-prompts@1588"

},
"packageManager": "yarn@4.13.0"
}
Loading
Loading