Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #768 +/- ##
============================================
- Coverage 82.12% 81.07% -1.06%
- Complexity 935 955 +20
============================================
Files 44 44
Lines 2154 2219 +65
============================================
+ Hits 1769 1799 +30
- Misses 385 420 +35
|
felixfbecker
requested changes
Nov 16, 2019
Owner
felixfbecker
left a comment
felixfbecker
left a comment
There was a problem hiding this comment.
Thanks for taking a stab at this! However, the issues in the description seem like blockers before merging this.
Author
|
I rewrote the definition finding and added code to update the index after the rename. The issues I described earlier should be solved with this. |
rummatee
commented
Nov 28, 2019
| */ | ||
| private function removeIndexedDefinition(int $level, array $parts, array &$storage, array &$rootStorage) | ||
| { | ||
| if (empty($parts)) { |
Author
There was a problem hiding this comment.
I don't really understand this function well enough to be confident about this code, but it fixes an exception that I got before and it seems intuitively right to have a base case for the recursion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to implement the rename function. Therefore it implements #21 .
There are however still some limitations:
If there isn't a reference in the same file, as the definition, the definition doesn't get changed.
Also at least in my editor (nvim) it is only possible to do one rename and it's necessary to restart before doing the next rename.
I would appreciate any help with these issues or any further comments.