Skip to content

Conversation

@feO2x
Copy link
Owner

@feO2x feO2x commented Jul 8, 2025

This pull request introduces several enhancements to the project, focusing on build optimization, release automation, and metadata updates. Key changes include the creation of a reusable GitHub Action for caching NuGet packages, the addition of a workflow for publishing releases to NuGet, and updates to project properties for better package metadata.

Build Optimization:

Release Automation:

  • .github/workflows/release-on-nuget.yml: Added a new workflow to automate the release process on NuGet, including steps for code checkout, dependency caching, SNK file preparation, package creation, and pushing to NuGet.

Metadata Updates:

  • Directory.Build.props: Added metadata properties such as Authors, Company, Copyright, RootNamespace, and Version to improve NuGet package details. Enabled treating warnings as errors in Release builds for stricter code quality.
  • Directory.Packages.props: Added the Microsoft.SourceLink.GitHub package to enable source link support for NuGet packages.

Solution Structure:

  • Light.TemporaryStreams.sln: Updated the solution file to include the new cache-nuget action and release-on-nuget.yml workflow, ensuring proper integration into the project structure. [1] [2] [3]

feO2x added 16 commits July 7, 2025 08:01
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
…treamAsync

Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
…yStreamAsync

Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
@feO2x feO2x requested a review from Copilot July 8, 2025 20:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR lays groundwork for the v1.0.0 release by updating tests, introducing a new stream-reset API, enriching NuGet package metadata, and automating the release workflow.

  • Refactor tests to assert stream position resets
  • Add ResetStreamPosition API and call it after copy operations
  • Enhance project files with descriptions and release notes (incl. typos to fix)
  • Introduce a GitHub Actions workflow for publishing to NuGet

Reviewed Changes

Copilot reviewed 17 out of 20 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tests/.../CopyToTemporaryStreamTests.cs Replaced NotBeNull assertions with Position == 0 checks
src/Light.TemporaryStreams.Core/TemporaryStreamServiceExtensions.cs & TemporaryStream.cs Added ResetStreamPosition method and calls
src/Light.TemporaryStreams/Light.TemporaryStreams.csproj Added <Decscription> and <PackageReleaseNotes>
src/Light.TemporaryStreams.Core/Light.TemporaryStreams.Core.csproj Added <Description> and <PackageReleaseNotes>
.github/workflows/release-on-nuget.yml New workflow to pack and push packages to NuGet
Comments suppressed due to low confidence (1)

.github/workflows/release-on-nuget.yml:24

  • The shell command is using > instead of a pipe; it should be echo "$SNK" | base64 --decode > Light.TemporaryStreams.snk to correctly decode the SNK file.
        run: echo "$SNK" > base64 --decode > Light.TemporaryStreams.snk

feO2x added 4 commits July 8, 2025 22:31
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
@feO2x feO2x self-assigned this Jul 8, 2025
@feO2x feO2x added the enhancement New feature or request label Jul 8, 2025
@feO2x feO2x merged commit 0da9e08 into main Jul 8, 2025
1 check passed
@feO2x feO2x deleted the preparation-for-v1-release branch July 8, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants