-
Notifications
You must be signed in to change notification settings - Fork 1
Preparation for v1 release #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
…treamAsync Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
…yStreamAsync Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR lays groundwork for the v1.0.0 release by updating tests, introducing a new stream-reset API, enriching NuGet package metadata, and automating the release workflow.
- Refactor tests to assert stream position resets
- Add
ResetStreamPositionAPI and call it after copy operations - Enhance project files with descriptions and release notes (incl. typos to fix)
- Introduce a GitHub Actions workflow for publishing to NuGet
Reviewed Changes
Copilot reviewed 17 out of 20 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/.../CopyToTemporaryStreamTests.cs | Replaced NotBeNull assertions with Position == 0 checks |
| src/Light.TemporaryStreams.Core/TemporaryStreamServiceExtensions.cs & TemporaryStream.cs | Added ResetStreamPosition method and calls |
| src/Light.TemporaryStreams/Light.TemporaryStreams.csproj | Added <Decscription> and <PackageReleaseNotes> |
| src/Light.TemporaryStreams.Core/Light.TemporaryStreams.Core.csproj | Added <Description> and <PackageReleaseNotes> |
| .github/workflows/release-on-nuget.yml | New workflow to pack and push packages to NuGet |
Comments suppressed due to low confidence (1)
.github/workflows/release-on-nuget.yml:24
- The shell command is using
>instead of a pipe; it should beecho "$SNK" | base64 --decode > Light.TemporaryStreams.snkto correctly decode the SNK file.
run: echo "$SNK" > base64 --decode > Light.TemporaryStreams.snk
src/Light.TemporaryStreams.Core/Light.TemporaryStreams.Core.csproj
Outdated
Show resolved
Hide resolved
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
This pull request introduces several enhancements to the project, focusing on build optimization, release automation, and metadata updates. Key changes include the creation of a reusable GitHub Action for caching NuGet packages, the addition of a workflow for publishing releases to NuGet, and updates to project properties for better package metadata.
Build Optimization:
.github/actions/cache-nuget/action.yml: Created a composite GitHub Action to cache NuGet packages, improving build speed by reusing package dependencies across workflows..github/workflows/build-and-test.yml: Updated the build and test workflow to use the newcache-nugetaction instead of directly invokingactions/cache.Release Automation:
.github/workflows/release-on-nuget.yml: Added a new workflow to automate the release process on NuGet, including steps for code checkout, dependency caching, SNK file preparation, package creation, and pushing to NuGet.Metadata Updates:
Directory.Build.props: Added metadata properties such asAuthors,Company,Copyright,RootNamespace, andVersionto improve NuGet package details. Enabled treating warnings as errors inReleasebuilds for stricter code quality.Directory.Packages.props: Added theMicrosoft.SourceLink.GitHubpackage to enable source link support for NuGet packages.Solution Structure:
Light.TemporaryStreams.sln: Updated the solution file to include the newcache-nugetaction andrelease-on-nuget.ymlworkflow, ensuring proper integration into the project structure. [1] [2] [3]