-
Notifications
You must be signed in to change notification settings - Fork 1
Add comprehensive tests for CopyToTemporaryStreamAsync overloads and fix plugin bugs #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: feO2x <7884158+feO2x@users.noreply.github.com>
…s and fix plugin bugs Co-authored-by: feO2x <7884158+feO2x@users.noreply.github.com>
Co-authored-by: feO2x <7884158+feO2x@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Automated tests for CopyToTemporaryStreamAsync overloads
Add comprehensive tests for CopyToTemporaryStreamAsync overloads and fix plugin bugs
Jul 1, 2025
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
…reamService interface Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
feO2x
approved these changes
Jul 5, 2025
Owner
feO2x
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I fixed some things, but overall great work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements comprehensive automated tests for the two
CopyToTemporaryStreamAsyncextension method overloads as requested in the issue. The tests follow Sociable Unit Testing principles, testing real components in combination without test doubles.🧪 Tests Added
8 comprehensive tests covering both overloads:
Basic CopyToTemporaryStreamAsync overload:
Plugin-enabled CopyToTemporaryStreamAsync overload:
All tests verify:
🐛 Critical Bugs Fixed
During test development, two critical bugs were discovered and fixed in the existing codebase:
1. Plugin Setup Bug in TemporaryStreamServiceExtensions
Issue: Line 126 was incorrectly passing the
sourcestream to plugin setup instead of theoutermostStream(destination).This caused plugins to wrap the wrong stream, leading to
NotSupportedException: Memory stream is not expandable.2. Multiple Hash Calculator Bug in HashingPlugin
Issue: The plugin wasn't properly chaining multiple hash calculators - all calculators were wrapping the same inner stream instead of creating a chain.
📁 Test Resources
Added sample PDF files as requested:
less-than-80KB.pdf(596 bytes) - triggers MemoryStream usagemore-than-80KB.pdf(80,602 bytes) - triggers FileStream usage✅ Results
Fixes #6.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.