-
-
Notifications
You must be signed in to change notification settings - Fork 67
chore(lint): Use shared eslint config #1844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
02a98c5
chore(lint): Use shared eslint config
fb55 4983c0c
chore(lint): format biome config
fb55 eea60c9
chore(lint): Use shared eslint config
fb55 7fd3000
stricter biome config
fb55 7360b41
Merge branch 'master' into shared-config
fb55 922d414
fixes
fb55 1c1ae3d
Merge branch 'master' into shared-config
fb55 dadb742
Update package.json
fb55 defb1f5
fix
fb55 8330ee6
target es2022
fb55 915e787
Update node.ts
fb55 11efd6a
Merge branch 'master' into shared-config
fb55 8a83365
fix
fb55 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| { | ||
| "$schema": "https://biomejs.dev/schemas/2.4.6/schema.json", | ||
| "vcs": { | ||
| "enabled": true, | ||
| "clientKind": "git", | ||
| "useIgnoreFile": true | ||
| }, | ||
| "files": { | ||
| "ignoreUnknown": true, | ||
| "includes": ["**/*.{ts,md,json,yml}", "!**/.*"] | ||
| }, | ||
| "formatter": { | ||
| "enabled": true, | ||
| "indentStyle": "space", | ||
| "indentWidth": 4 | ||
| }, | ||
| "javascript": { | ||
| "formatter": {} | ||
| }, | ||
| "linter": { | ||
| "enabled": true, | ||
| "rules": { | ||
| "recommended": true, | ||
| "complexity": { | ||
| "noUselessStringConcat": "error", | ||
| "noUselessUndefined": "error", | ||
| "useSimplifiedLogicExpression": "error", | ||
| "useWhile": "error" | ||
| }, | ||
| "performance": { | ||
| "useTopLevelRegex": "error" | ||
| }, | ||
| "suspicious": { | ||
| "noConstantBinaryExpressions": "error", | ||
| "useAwait": "error" | ||
| }, | ||
| "style": { | ||
| "noInferrableTypes": "error", | ||
| "noNegationElse": "error", | ||
| "noUnusedTemplateLiteral": "error", | ||
| "noUselessElse": "error", | ||
| "noYodaExpression": "error", | ||
| "useAsConstAssertion": "error", | ||
| "useCollapsedElseIf": "error", | ||
| "useCollapsedIf": "error", | ||
| "useConsistentArrayType": "error", | ||
| "useConsistentArrowReturn": "error", | ||
| "useConsistentMemberAccessibility": "error", | ||
| "useConsistentObjectDefinitions": "error", | ||
| "useConsistentTypeDefinitions": "error", | ||
| "useDefaultParameterLast": "error", | ||
| "useExplicitLengthCheck": "error", | ||
| "useFilenamingConvention": "error", | ||
| "useNumberNamespace": "error", | ||
| "useNumericSeparators": "error", | ||
| "useObjectSpread": "error", | ||
| "useShorthandAssign": "error", | ||
| "useUnifiedTypeSignatures": "error" | ||
| } | ||
| } | ||
| }, | ||
| "assist": { | ||
| "enabled": true, | ||
| "actions": { | ||
| "source": { | ||
| "organizeImports": "on" | ||
| } | ||
| } | ||
| }, | ||
| "overrides": [ | ||
| { | ||
| "includes": ["**/*.{test,spec}.ts", "test/**/*.ts"], | ||
| "javascript": { | ||
| "globals": [ | ||
| "jest", | ||
| "describe", | ||
| "it", | ||
| "beforeEach", | ||
| "afterEach", | ||
| "expect", | ||
| "vi" | ||
| ] | ||
| } | ||
| }, | ||
| { | ||
| "includes": ["**/*.ts", "**/*.cts", "**/*.mts", "**/*.tsx"], | ||
| "linter": { | ||
| "rules": { | ||
| "complexity": { | ||
| "useLiteralKeys": "off" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import { includeIgnoreFile } from '@eslint/compat'; | ||
| import feedicFlatConfig from '@feedic/eslint-config'; | ||
| import { commonTypeScriptRules } from '@feedic/eslint-config/typescript'; | ||
| import tseslint from 'typescript-eslint'; | ||
| import { defineConfig } from 'eslint/config'; | ||
| import { fileURLToPath } from 'node:url'; | ||
| import eslintConfigBiome from 'eslint-config-biome'; | ||
|
|
||
| const gitignorePath = fileURLToPath(new URL('.gitignore', import.meta.url)); | ||
|
|
||
| export default defineConfig([ | ||
| includeIgnoreFile(gitignorePath), | ||
| { | ||
| linterOptions: { | ||
| reportUnusedDisableDirectives: 'error', | ||
| }, | ||
| }, | ||
| { | ||
| ignores: ['eslint.config.{js,cjs,mjs}'], | ||
| }, | ||
| ...feedicFlatConfig, | ||
| { | ||
| files: ['**/*.spec.ts'], | ||
| rules: { | ||
| 'n/no-unsupported-features/node-builtins': 0, | ||
| 'unicorn/import-style': 0, | ||
| 'unicorn/no-array-callback-reference': 0, | ||
| }, | ||
| }, | ||
| { | ||
| files: [ | ||
| "**/*.ts" | ||
| ], | ||
| extends: [...tseslint.configs.recommended], | ||
| languageOptions: { | ||
| parser: tseslint.parser, | ||
| parserOptions: { | ||
| "sourceType": "module", | ||
| "project": "./tsconfig.eslint.json" | ||
| }, | ||
| }, | ||
| rules: { | ||
| ...commonTypeScriptRules, | ||
| "n/no-unsupported-features/es-builtins": 0, | ||
|
fb55 marked this conversation as resolved.
|
||
| }, | ||
| }, | ||
| eslintConfigBiome | ||
| ]); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.