Fix: display raw token after creation#35
Open
etagwerker wants to merge 1 commit into
Open
Conversation
The earlier review fix moved the raw token off `flash` onto an instance variable to avoid serializing it into the session cookie, but the view kept reading `flash[:raw_token]`. As a result the success banner shows after creation but the actual token never renders, so users can't copy it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app/views/personal_access_tokens/index.html.erbreadsflash[:raw_token], but the controller was updated to set@raw_tokendirectly (the earlier change addressed a review comment about not carrying the raw token through the session cookie).This swaps the view to read
@raw_token, which matches whatPersonalAccessTokensController#createalready sets.How to verify
/personal_access_tokens, name a token and click "Generate token"lib_…token in a code box🤖 Generated with Claude Code