refactor: invert progress calculation for inside variant#4483
Merged
ComputelessComputer merged 1 commit intomainfrom Mar 10, 2026
Merged
refactor: invert progress calculation for inside variant#4483ComputelessComputer merged 1 commit intomainfrom
ComputelessComputer merged 1 commit intomainfrom
Conversation
Extract progress calculation to insideOffset variable and invert the formula from progress * 100% to (1 - progress) * 100% so that progress 0 positions the indicator at bottom (100%) and progress 1 at top (0%). Add test coverage to verify the inside variant renders progress from bottom to top as expected.
✅ Deploy Preview for hyprnote-storybook canceled.
|
✅ Deploy Preview for hyprnote canceled.
|
jack-jackhui
pushed a commit
to jack-jackhui/char
that referenced
this pull request
Mar 15, 2026
Extract progress calculation to insideOffset variable and invert the formula from progress * 100% to (1 - progress) * 100% so that progress 0 positions the indicator at bottom (100%) and progress 1 at top (0%). Add test coverage to verify the inside variant renders progress from bottom to top as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract progress calculation to insideOffset variable and invert the formula from progress * 100% to (1 - progress) * 100% so that progress 0 positions the indicator at bottom (100%) and progress 1 at top (0%).
Add test coverage to verify the inside variant renders progress from bottom to top as expected.