-
-
Notifications
You must be signed in to change notification settings - Fork 846
add model_dump options to sqlmodel_update #1897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
A00474880
wants to merge
11
commits into
fastapi:main
Choose a base branch
from
A00474880:improve_sqlmodel_update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+52
−19
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4885b99
add model_dump options to sqlmodel_update
A00474880 3d17d08
🎨 Auto format
pre-commit-ci-lite[bot] 35ddc4c
Merge branch 'main' into improve_sqlmodel_update
A00474880 59d71de
type support for model_dump_kwargs
A00474880 ac676fb
creates temp UpdateModel to avoid issues with SQLModel's serializatio…
A00474880 d9ffaf1
updating test
A00474880 f399589
Merge remote-tracking branch 'origin/improve_sqlmodel_update' into im…
A00474880 66c8b88
🎨 Auto format
pre-commit-ci-lite[bot] 8fe99e9
remove defaults from _ModelDumpKwargs TypedDict
A00474880 0295137
Merge remote-tracking branch 'origin/improve_sqlmodel_update' into im…
A00474880 51ad5c3
🎨 Auto format
pre-commit-ci-lite[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break use cases with models that have fields with
exclude=True:.. and probably some other cases when model has settings that change the default serialization schema.