🗑️ Deprecate const and unique_items in Field
#1732
Open
+65
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
constandunique_itemsparameters inFieldare deprecated in Pydantic V2 (const, unique_items):This PR reflects this change.
I ended up just emitting a warning (not error) in case someone use these parameters. Should we also raise error as Pydantic does?
These parameters don't work (just ignored) on current SQLModel version. And they never worked with SQLMOdel + Pydantic V2.
So, not sure we need to mark this PR as
breaking, but I did it it worked in some previous versions with Pydantic V1