fix: Ensure consistent passphrase length#2025
Closed
jakob1379 wants to merge 1 commit intofastapi:masterfrom
Closed
fix: Ensure consistent passphrase length#2025jakob1379 wants to merge 1 commit intofastapi:masterfrom
jakob1379 wants to merge 1 commit intofastapi:masterfrom
Conversation
Member
|
Which services complained? |
Author
|
I believe it was adminer |
Member
|
Strange, as adminer doesn't take any secrets of its own, only the ones from Postgres 🤔 I would say, we could close this one and wait for someone else to bump into this (or you if it happens), so that I can replicate the issue and confirm this is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that the generated passphrases have a consistent length.
During the docker compose, some service complained that the secret were too long, which is caused by the
python -c "import secrets; print(secrets.token_urlsafe(32))which is in bytes, not characters.