feat(broadcasting): add channels.py publishable stub for Reverb#115
Closed
bedus-creation wants to merge 1 commit into
Closed
feat(broadcasting): add channels.py publishable stub for Reverb#115bedus-creation wants to merge 1 commit into
bedus-creation wants to merge 1 commit into
Conversation
Adds fastapi_startkit/src/fastapi_startkit/broadcasting/stubs/channels.py — the template that ReverbProvider publishes to routes/channels.py in the application. Includes a documented @Broadcast.channel() example with typed wildcard injection so developers know the pattern immediately. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
Review — Superseded by PR #112This PR adds PR #112 is the authoritative implementation for tasks #147–#150. It already includes:
Recommendation: Close this PR as superseded by #112. Merging both would cause a conflict on the stub files, and the content in #112 already covers this use case. Once #112's two blocking issues are fixed and it is merged, the stub will be available via |
Contributor
Author
|
Superseded — channels.py stub already shipped in merged PR #112. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fastapi_startkit/src/fastapi_startkit/broadcasting/stubs/channels.py— the publishable stub thatReverbProviderwill copy toroutes/channels.pywhen a developer runs the publish command@Broadcast.channel("orders.{order_id}")example with typed wildcard injection so developers know the authorization pattern immediatelystubs/__init__.pypackage markerRelated
application/routes/channels.pyadded in the fastapi-startkit application template repodocs/reverb.mdadded in the fastapi-startkit.github.io docs repoTest plan
stubs/channels.pyis importable@Broadcast.channelpattern documented indocs/reverb.md🤖 Generated with Claude Code