Less resize on splitters changes#346
Merged
fantaisie-software merged 2 commits intofantaisie-software:develfrom Mar 25, 2026
Merged
Less resize on splitters changes#346fantaisie-software merged 2 commits intofantaisie-software:develfrom
fantaisie-software merged 2 commits intofantaisie-software:develfrom
Conversation
UpdateSourceContainer() on splitters changes only if there is a real change in the splitters positions. For fewer processes, resizing, redraw. However, wouldn't it be better if, in the Gadget Library, only Splitter events with a real change of status (position) were processed?
fantaisie-software
requested changes
Mar 25, 2026
Owner
fantaisie-software
left a comment
fantaisie-software
left a comment
There was a problem hiding this comment.
Looks good to me, could you remove the Debug statements ?
I don't think we will patch the splitter gadget as introducing a cache could lead to other issues (I tried and it failed in a few cases)
Remove the Debug statements who was there just to help test it. Thanks for the explanation of the Splitter events.
Contributor
Author
|
I've removed the debugging statements that were only there to make testing easier. |
fantaisie-software
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UpdateSourceContainer() on splitters changes only if there is a real change in the splitters positions. For fewer processes, resizing, redraw.
However, wouldn't it be better if, in the Gadget Library, only Splitter events with a real state change (position) were processed?
Moving the mouse Horizontally over a Horizontal Splitter does nothing and is useless, it shouldn't send an event (resize > redraw for us). And vice versa for the Vertical Splitter