-
Notifications
You must be signed in to change notification settings - Fork 40
Clarify steps in RELEASE.MD #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Carrie Dils <carriedils@gmail.com>
joedolson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor additional changes
|
|
||
| 2. Check **Set as the latest release**. | ||
|
|
||
| 3. Check **Create a discussion for this release** and choose the **Announcements** category. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not everybody has sufficient permissions to create discussions in the Announcements category; either that needs to be something that gets assigned to anybody who can do a release (and is a requirement to do a release), or there needs to be an alternate set of instructions if those permissions aren't available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great point and surfaces the issue of "who has sufficient permissions" to be a release manager. Issue created to discuss this here: fairpm/tsc#171
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See 0. Ensure adequate permissions in updated PR
Signed-off-by: Carrie Dils <carriedils@gmail.com>
joedolson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor clarification.
| To perform a release of FAIR Connect, you need the following: | ||
| - `write` or higher permissions on the [FAIR Connect repository](https://github.com/fairpm/fair-plugin) | ||
| - `maintain` or higher permissions on the [TSC repository](https://github.com/fairpm/tsc) (this is required to post a Discussion per step 7.3.) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarification: I believe maintain is only required to post a discussion in the 'Announcements' category. E.g., I can post a new discussion, but I can't post it in the 'Announcements' category.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussions are org-level are "hosted" on the TSC repo, so any category that is locked down, such as 'Announcements' requires someone with maintain or admin privileges at the repo level.
Would this clarify it?
(this is required to post a Discussion to the Announcements category per step 7.3.)
Fixes #398