URI: accept more valid characters in authority #394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validation rejected some needed valid URIs. - mds://*:1234 -> setting the host as asterisk is used in zeromq to bind to all interfaces - http://[::1]:123 -> ipv6 addresses as the host part should be valid. No immediate usecase but added it since I was touching the code. There are probably more cases, so this should be followed up at some point by testing against a big corpus of valid URIs. Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation rejected some needed valid URIs.
There are probably more cases, so this should be followed up at some point by testing against a big corpus of valid URIs.