fix(SDK): Added Holdings Mode for PA API Code Snippet#92
Open
avinashpipalwa wants to merge 2 commits intomasterfrom
Open
fix(SDK): Added Holdings Mode for PA API Code Snippet#92avinashpipalwa wants to merge 2 commits intomasterfrom
avinashpipalwa wants to merge 2 commits intomasterfrom
Conversation
Made the changes as per the requirement. Tested this and can see in the post body the Holdings mode which we passed as an input.
vamshimupparaju
approved these changes
Jul 6, 2022
Contributor
vamshimupparaju
left a comment
vamshimupparaju
left a comment
There was a problem hiding this comment.
Looks good to me
ksreeramoj
reviewed
Jul 6, 2022
| print("PA Component Id: " + component_id) | ||
| pa_accounts = [PAIdentifier(id=portfolio)] | ||
| pa_benchmarks = [PAIdentifier(id=benchmark)] | ||
| pa_accounts = [PAIdentifier(id=portfolio,holdingsmode=holdings)] |
There was a problem hiding this comment.
Very minor: please add space after a comma.
ksreeramoj
approved these changes
Jul 6, 2022
Added a space after comma
| startdate = "20180101" | ||
| enddate = "20181231" | ||
| frequency = "Monthly" | ||
| holdings = "B&H" |
Contributor
There was a problem hiding this comment.
Is this better to make the variable name too as holdingsmode? Also, it may be good to have this variable at line 49 as it is related to accounts and benchmarks.
ksreeramoj
approved these changes
Aug 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made the changes as per the requirement.
Tested this and can see in the post body the Holdings mode which we passed as an input.