Trigger docker build when buildinfo.json is updated#611
Open
bastiandg wants to merge 1 commit intofactoriotools:masterfrom
Open
Trigger docker build when buildinfo.json is updated#611bastiandg wants to merge 1 commit intofactoriotools:masterfrom
bastiandg wants to merge 1 commit intofactoriotools:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The buildinfo.json is correctly updated. As can be seen here: 18a4834
The build and push pipeline is not triggered though: https://github.com/factoriotools/factorio-docker/actions/workflows/docker-build.yml . It was last manually triggered in January.
After merging this, updating the buildinfo.json also triggers the build pipeline. For 2.0.76 is to be triggered manually one last time.
There is another PR #610 that attempts something similar. Putting the trigger on the update pipeline rather than the other way around, saves a lot of unnecessary runs (even if only skips).