Skip to content

Comments

Downgrade supporting for Xcode 15#5

Closed
mlch911 wants to merge 4 commits intofacebookincubator:mainfrom
mlch911:xcode15
Closed

Downgrade supporting for Xcode 15#5
mlch911 wants to merge 4 commits intofacebookincubator:mainfrom
mlch911:xcode15

Conversation

@mlch911
Copy link
Contributor

@mlch911 mlch911 commented Dec 1, 2025

Downgrade the SPM for supporting running in Xcode 15.
Downgrade the Demo project for supporting running in Xcode 15.
Add MacroTesting for better experience writing tests.

@meta-cla meta-cla bot added the cla signed label Dec 1, 2025
),
.init(
message: """
Method 'layoutSubviews' is missing required implementation call. Below Swift 6.0, you must manually add the following call:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, for raising the diff.
Am I correct to understand that with Swift 5.9, one would always have to provide implementation for willMoveToWindow and layoutSubviews manually?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's correct.

@constantine-fry
Copy link
Contributor

Hi @mlch911, thanks for the effort you put into this PR. After looking closely at the diff, I’m going to close this without merging.

The main reason is that I want to ensure QuickLayout works across all supported OS and Swift versions without any functional or integration differences. This PR would make the integration process for Swift 5.9 distinct from other versions, and I’m aiming for a single, unified setup experience for everyone.

As an alternative for your specific use case, I suggest looking into manual integration: https://facebookincubator.github.io/QuickLayout/how-to-use/manual-layout-integration/

While this may require some changes to the package file, please keep in mind that you would also lose automatic view hierarchy management and appearance animations.

I appreciate the contribution nonetheless!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants