Skip to content

fix(devtools): clear highlight when mouse leaves DevTools panel #36177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
petertdinh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(devtools): clear highlight when mouse leaves DevTools panel #36177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions packages/react-devtools-shared/src/devtools/views/Components/Tree.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,23 @@ export default function Tree(): React.Node {

const handleMouseLeave = clearHighlightHostInstance;

// The synthetic onMouseLeave on the tree div only fires within the document,
// so we need a native listener on the document itself.
useEffect(() => {
const container = focusTargetRef.current;
if (container == null) {
return;
}
const ownerDocument = container.ownerDocument;
ownerDocument.addEventListener('mouseleave', clearHighlightHostInstance);
return () => {
ownerDocument.removeEventListener(
'mouseleave',
clearHighlightHostInstance,
);
};
}, [clearHighlightHostInstance]);

// Let react-window know to re-render any time the underlying tree data changes.
// This includes the owner context, since it controls a filtered view of the tree.
const itemData = useMemo<ItemData>(
Expand Down
Loading