Fix ViewTransition onExit cleanup timing on unmount#35950
Open
angular-bootstrap wants to merge 2 commits intofacebook:mainfrom
Open
Fix ViewTransition onExit cleanup timing on unmount#35950angular-bootstrap wants to merge 2 commits intofacebook:mainfrom
angular-bootstrap wants to merge 2 commits intofacebook:mainfrom
Conversation
|
Comparing: 4cc5b7a...5d7626b Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a ViewTransition cleanup timing inconsistency for
onExit.Previously,
onExitcleanup was attached to transition finish, so it could be delayed even when the transition subtree had already unmounted. This change marksonExitcleanup as unmount-bound and executes it immediately for that path, matching expected unmount cleanup behavior.Changes
cleanupOnUnmountsupport toscheduleViewTransitionEvent.onExitscheduling withcleanupOnUnmount: true.ReactDOMViewTransition-test.Test Plan
yarn test ReactDOMViewTransition-test --runInBandIssue
Closes #35855