[noop] Fail tests on unasserted recoverable errors#35948
Open
eps1lon wants to merge 1 commit intofacebook:mainfrom
Open
[noop] Fail tests on unasserted recoverable errors#35948eps1lon wants to merge 1 commit intofacebook:mainfrom
eps1lon wants to merge 1 commit intofacebook:mainfrom
Conversation
github-actions
bot
added
the
React Core Team
|
Comparing: 4cc5b7a...1b61b6a Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
eps1lon
force-pushed
the
sebbie/03-02-_noop_fail_tests_on_unasserted_recoverable_errors
branch
3 times, most recently
from
4d351a7 to
a098999
Compare
eps1lon
force-pushed
the
sebbie/03-02-_noop_fail_tests_on_unasserted_recoverable_errors
branch
from
a098999 to
1b61b6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
react-noop-rendererpreviously swallowed recoverable errors (fromonRecoverableError). Now we pass those through toconsole.errorso that we fail the test unlessassertConsoleError