fix: initialize transition start time with performance.now()#35726
fix: initialize transition start time with performance.now()#35726subhamkumarr wants to merge 2 commits intofacebook:mainfrom
Conversation
|
Hi @subhamkumarr! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
@hoxyq @unstubbable @jackpope |
Details
packages/react/src/ReactStartTransition.js: Added anow()helper (usingperformance.now()with aDate.now()fallback) and used it to setcurrentTransition.startTime.packages/react-reconciler/src/ReactFiberWorkLoop.js: Removed the check fortransition.startTime === -1and the subsequent assignment, as it is no longer needed.Motivation
Previously,
startTimewas initialized to-1and lazily updated upon scheduling an update. This behavior was inconsistent withuseTransitionand could lead to inaccurate timestamps if there was a delay between the transition start and the actual update scheduling. This change standardizes the behavior and ensures accurate timing for transition tracing.How to Test
enableTransitionTracingfeature flag.yarn test ReactTransitionTracing.Checklist
yarn test ReactTransitionTracing).Fixes #35725