Skip to content

Conversation

@aarushdubey
Copy link

Summary

Fixes #35490 - Inefficient Regular Expression Complexity in React DevTools

Changes

  • Replaced vulnerable regex pattern in Firefox stack trace parser with secure alternative
    • Changed (?:.*".+")?[^@]* to (?:"[^"]+")?[^@]*
    • Uses negated character class instead of nested quantifiers to prevent catastrophic backtracking
    • Added regression test to prevent future ReDoS vulnerabilities

Performance Impact

  • Before: Malicious input causes 2500+ ms freeze
    • After: Same input completes in < 1ms
    • Maintains identical matching behavior for valid stack traces

Testing

  • All existing tests pass (133/133)
    • Added regression test with proof-of-concept malicious input
    • Test ensures parsing completes in < 100ms

Reference

Replace nested quantifiers with negated character class to prevent
catastrophic backtracking. Changes (?:.*\".+\")? to (?:\"[^\"]\")?

Fixes facebook#35490
@meta-cla
Copy link

meta-cla bot commented Jan 23, 2026

Hi @aarushdubey!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla
Copy link

meta-cla bot commented Jan 23, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed label Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Inefficient Regular Expression Complexity in react

1 participant