-
Notifications
You must be signed in to change notification settings - Fork 50.4k
Fix lazy thenable suspension race #35423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
3b3cfe6 to
46604ca
Compare
|
This PR seems to also fix useId causing hydration issues. At least vercel/next.js#84029 and #35210 would be fixed. |
acdlite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Great fix. Do you think you'd be able to write a regression test that reproduces the useId error you're referencing? (If not, I think it's fine to land as is.)
|
Comparing: 4a3d993...5027732 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
acdlite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually nvm I think we need to add a regression test before landing this
|
The failing devtools test is also sus though it might just be a missing |
Summary
How did you test this change?
Fixes #35399