Skip to content

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Nov 26, 2025

Fixes #33983 (comment)
See https://issues.chromium.org/u/1/issues/462747680

Seems like chrome.devtools.panels.openResource is not actually the default behavior for the resource handler. It's erroring when trying to open URLs that don't point to Chrome Resources and not doing anything.

E.g. clicking on https://google.com does nothing.

Falling back to window.open in case openResource errors. https://developer.chrome.com/docs/extensions/reference/api/devtools/panels#method-openResource doesn't document the parameter to the callback but it returns an error-like object.

Test plan

  1. Load extension from CI artifact
    Click on the link from console.log('https://google.com'). File links also work (e.g. console.log('file://404'))

@meta-cla meta-cla bot added the CLA Signed label Nov 26, 2025
@eps1lon eps1lon changed the title [devtools] Fix console links not being openable [DevTools] Fix console links not being openable Nov 26, 2025
@eps1lon eps1lon force-pushed the sebbie/11-26-_devtools_fix_console_links_not_being_openable branch from 1825f21 to 82b4ac5 Compare January 21, 2026 09:11
@eps1lon eps1lon marked this pull request as ready for review January 21, 2026 09:15
@eps1lon eps1lon requested a review from hoxyq January 21, 2026 09:15
@eps1lon eps1lon merged commit 7fccd6b into facebook:main Jan 21, 2026
237 checks passed
@eps1lon eps1lon deleted the sebbie/11-26-_devtools_fix_console_links_not_being_openable branch January 21, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants