Move event dispatch logic from FabricUIManager into SurfaceMountingManager (#56659)#56659
Closed
javache wants to merge 1 commit into
Closed
Move event dispatch logic from FabricUIManager into SurfaceMountingManager (#56659)#56659javache wants to merge 1 commit into
javache wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D103007280. |
meta-codesync
Bot
changed the title
javache
added a commit
to javache/react-native
that referenced
this pull request
May 5, 2026
…nager (facebook#56659) Summary: Refactor: consolidate the event dispatch decision (enqueue vs direct dispatch) into `SurfaceMountingManager.dispatchEvent`, removing the 3-way branching from `FabricUIManager.receiveEvent`. The sync event path remains in `FabricUIManager`. This moves `getEventEmitter`, `getViewExists`, and `enqueuePendingEvent` calls behind a single `dispatchEvent` entry point, making the ordering logic fully encapsulated in `SurfaceMountingManager`. Changelog: [Internal] Reviewed By: zeyap Differential Revision: D103007280
javache
added a commit
to javache/react-native
that referenced
this pull request
May 6, 2026
…nager (facebook#56659) Summary: Refactor: consolidate the event dispatch decision (enqueue vs direct dispatch) into `SurfaceMountingManager.dispatchEvent`, removing the 3-way branching from `FabricUIManager.receiveEvent`. The sync event path remains in `FabricUIManager`. This moves `getEventEmitter`, `getViewExists`, and `enqueuePendingEvent` calls behind a single `dispatchEvent` entry point, making the ordering logic fully encapsulated in `SurfaceMountingManager`. Changelog: [Internal] Reviewed By: zeyap Differential Revision: D103007280
…nager (facebook#56659) Summary: Refactor: consolidate the event dispatch decision (enqueue vs direct dispatch) into `SurfaceMountingManager.dispatchEvent`, removing the 3-way branching from `FabricUIManager.receiveEvent`. The sync event path remains in `FabricUIManager`. This moves `getEventEmitter`, `getViewExists`, and `enqueuePendingEvent` calls behind a single `dispatchEvent` entry point, making the ordering logic fully encapsulated in `SurfaceMountingManager`. Changelog: [Internal] Reviewed By: zeyap Differential Revision: D103007280
|
This pull request has been merged in 97fa2a4. |
Collaborator
|
This pull request was successfully merged by @javache in 97fa2a4 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Refactor: consolidate the event dispatch decision (enqueue vs direct dispatch) into
SurfaceMountingManager.dispatchEvent, removing the 3-way branching fromFabricUIManager.receiveEvent. The sync event path remains inFabricUIManager.This moves
getEventEmitter,getViewExists, andenqueuePendingEventcalls behind a singledispatchEvententry point, making the ordering logic fully encapsulated inSurfaceMountingManager.Changelog: [Internal]
Reviewed By: zeyap
Differential Revision: D103007280