Re-enabled VirtualizedList "retains batch render region when an item is appended" test#56653
Closed
chicio wants to merge 2 commits into
Closed
Re-enabled VirtualizedList "retains batch render region when an item is appended" test#56653chicio wants to merge 2 commits into
chicio wants to merge 2 commits into
Conversation
…d (react 19 differen) Co-authored-by: Copilot <copilot@github.com>
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
Contributor
Author
|
Hi @Abbondanzo and @cortinico, can someone of you help me to import this PR? Thanks 🙏 |
Contributor
|
@Abbondanzo can you take this one? |
|
@Abbondanzo has imported this pull request. If you are a Meta employee, you can view this in D104291284. |
cortinico
approved these changes
May 8, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
@Abbondanzo merged this pull request in c0bf154. |
Collaborator
|
This pull request was successfully merged by @chicio in c0bf154 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR is a follow-up of #56358, in order to improve and VirtualizedList tests.
I re-enabled the skipped test
retains batch render region when an item is appended.With React 19, the previous approach that was using
jest.runAllTimersAsyncin this test path was unstable because the pre-update render region could still be processing updates.I adopted the same approach used in #56358 by introducing a small helper function,
advanceUntilLastCellIndexRendered, which advances timers one step at a time and stops when the expected state is reached:cellsAroundViewport.last === items.length - 1.As part of this follow-up, I also aligned
advanceUntilRenderAreaChangedto use performNextBatch for consistent stepwise timer advancement.Changelog:
[GENERAL][FIXED] - Re-enabled VirtualizedList "retains batch render region when an item is appended" tes
Test Plan: