Fix array brackets appearing in the wrong place in the snapshot (#56214)#56214
Closed
j-piasecki wants to merge 3 commits intofacebook:mainfrom
Closed
Fix array brackets appearing in the wrong place in the snapshot (#56214)#56214j-piasecki wants to merge 3 commits intofacebook:mainfrom
j-piasecki wants to merge 3 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
facebook-github-tools
bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D98102328. |
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Mar 25, 2026
…book#56214) Summary: Changelog: [Internal] Snapshot generator was putting `[]` in wrong place when generating array type - it was adding it to the type name instead of the variable name. This diff addresses that. Differential Revision: D98102328
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Mar 25, 2026
…book#56214) Summary: Changelog: [Internal] Snapshot generator was putting `[]` in wrong place when generating array type - it was adding it to the type name instead of the variable name. This diff addresses that. Differential Revision: D98102328
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Mar 25, 2026
…book#56214) Summary: Changelog: [Internal] Snapshot generator was putting `[]` in wrong place when generating array type - it was adding it to the type name instead of the variable name. This diff addresses that. Differential Revision: D98102328
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Mar 25, 2026
…book#56214) Summary: Changelog: [Internal] Snapshot generator was putting `[]` in wrong place when generating array type - it was adding it to the type name instead of the variable name. This diff addresses that. Differential Revision: D98102328
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Mar 25, 2026
…book#56214) Summary: Changelog: [Internal] Snapshot generator was putting `[]` in wrong place when generating array type - it was adding it to the type name instead of the variable name. This diff addresses that. Differential Revision: D98102328
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Mar 25, 2026
…book#56214) Summary: Changelog: [Internal] Snapshot generator was putting `[]` in wrong place when generating array type - it was adding it to the type name instead of the variable name. This diff addresses that. Differential Revision: D98102328
added 2 commits
March 25, 2026 23:59
Summary: Changelog: [Internal] Correctly handles array types in member definitions in the API snapshot. Differential Revision: D97923375
Summary: Changelog: [Internal] When a class has multiple base classes, all defining a constructor with the same signature, the inherited constructors were being duplicated in the snapshot (for each base class). This diff deduplicates them. Differential Revision: D98102286
meta-codesync
bot
changed the title
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Mar 26, 2026
…book#56214) Summary: Changelog: [Internal] Snapshot generator was putting `[]` in wrong place when generating array type - it was adding it to the type name instead of the variable name. This diff addresses that. Reviewed By: cipolleschi Differential Revision: D98102328
j-piasecki
force-pushed
the
export-D98102328
branch
from
fd0770a to
b912dc6
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Mar 26, 2026
…book#56214) Summary: Changelog: [Internal] Snapshot generator was putting `[]` in wrong place when generating array type - it was adding it to the type name instead of the variable name. This diff addresses that. Reviewed By: cipolleschi Differential Revision: D98102328
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Mar 26, 2026
…book#56214) Summary: Changelog: [Internal] Snapshot generator was putting `[]` in wrong place when generating array type - it was adding it to the type name instead of the variable name. This diff addresses that. Reviewed By: cipolleschi Differential Revision: D98102328
j-piasecki
force-pushed
the
export-D98102328
branch
from
b912dc6 to
1b64446
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Mar 26, 2026
…book#56214) Summary: Changelog: [Internal] Snapshot generator was putting `[]` in wrong place when generating array type - it was adding it to the type name instead of the variable name. This diff addresses that. Reviewed By: cipolleschi Differential Revision: D98102328
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Mar 26, 2026
…book#56214) Summary: Changelog: [Internal] Snapshot generator was putting `[]` in wrong place when generating array type - it was adding it to the type name instead of the variable name. This diff addresses that. Reviewed By: cipolleschi Differential Revision: D98102328
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Mar 26, 2026
…book#56214) Summary: Changelog: [Internal] Snapshot generator was putting `[]` in wrong place when generating array type - it was adding it to the type name instead of the variable name. This diff addresses that. Reviewed By: cipolleschi Differential Revision: D98102328
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Mar 26, 2026
…book#56214) Summary: Changelog: [Internal] Snapshot generator was putting `[]` in wrong place when generating array type - it was adding it to the type name instead of the variable name. This diff addresses that. Reviewed By: cipolleschi Differential Revision: D98102328
j-piasecki
force-pushed
the
export-D98102328
branch
from
1b64446 to
367f69c
Compare
…book#56214) Summary: Pull Request resolved: facebook#56214 Changelog: [Internal] Snapshot generator was putting `[]` in wrong place when generating array type - it was adding it to the type name instead of the variable name. This diff addresses that. Reviewed By: cipolleschi Differential Revision: D98102328
j-piasecki
force-pushed
the
export-D98102328
branch
from
367f69c to
952475c
Compare
|
This pull request has been merged in cc9d06b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Snapshot generator was putting
[]in wrong place when generating array type - it was adding it to the type name instead of the variable name. This diff addresses that.Reviewed By: cipolleschi
Differential Revision: D98102328