Remove enableOptimizedBoxShadowParsing feature flag#56098
Open
sammy-SC wants to merge 1 commit intofacebook:mainfrom
Open
Remove enableOptimizedBoxShadowParsing feature flag#56098sammy-SC wants to merge 1 commit intofacebook:mainfrom
sammy-SC wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: changelog: [internal] Delete the `enableOptimizedBoxShadowParsing` flag and enable the optimized box shadow parsing by default. The optimization hoists regex patterns to module scope in `processBoxShadow.js`. Impact in production was small since this is a minor perf improvement to regex compilation. Differential Revision: D96594041
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
Delete the
enableOptimizedBoxShadowParsingflag and enable the optimized box shadow parsing by default. The optimization hoists regex patterns to module scope inprocessBoxShadow.js. Impact in production was small since this is a minor perf improvement to regex compilation.Differential Revision: D96594041