Add DrawCommandSpan Usable with PreparedLayoutTextView #55526
Closed
+54
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This allows character styling to be implemented, which can draw to the canvas, before or after main text draw, with full access to layout information. This allows very efficiently drawing some effects not possible on TextView. Changelog: [Android][Added] -Add Unstable DrawCommandSpan Usable with PreparedLayoutTextView Reviewed By: Abbondanzo Differential Revision: D92796048
|
@NickGerleman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92796048. |
meta-cla
bot
added
the
CLA Signed
|
This pull request has been merged in ad8ac5e. |
Collaborator
|
This pull request was successfully merged by @NickGerleman in ad8ac5e When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This allows character styling to be implemented, which can draw to the canvas, before or after main text draw, with full access to layout information. This allows very efficiently drawing some effects not possible on TextView.
Changelog:
[Android][Added] -Add Unstable DrawCommandSpan Usable with PreparedLayoutTextView
Reviewed By: Abbondanzo
Differential Revision: D92796048