fix(android): fix fadeDuration=0 not working w/ props 2.0 diffing

[hannojg]

Summary:

In our app we are using the props 2.0 diffing mechanism (ie getDiffProps in cpp).
I noticed that our <Image source={...} fadeDuration={0} /> were still showing with the default 300ms fade duration.

The issue is that we instantiate the fadeDuration in cpp with a default value of 0:

react-native/packages/react-native/ReactCommon/react/renderer/components/image/ImageProps.h

Line 40 in 4356259

Float fadeDuration{};

and then in the props diff implementation when comparing our prop value of 0 against the default, it will not be added to the final props, thus never set in the native image view:

react-native/packages/react-native/ReactCommon/react/renderer/components/image/ImageProps.cpp

Lines 273 to 275 in 4356259

	if (fadeDuration != oldProps->fadeDuration) {
	result["fadeDuration"] = fadeDuration;
	}

The native image view uses a default value of -1 so i thought to use the same here:

react-native/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/image/ReactImageView.kt

Line 104 in 4356259

private var fadeDurationMs = -1

Another solution could be to type the fadeDuration as std::optional, let me know what you prefer

Changelog:

[ANDROID] [FIXED] - Image fadeDuration=0 not working with props 2.0 enabled

Test Plan:

You can enable the props 2.0 feature flags in the RNTesterApp and check the image example!

[meta-codesync]

@fabriziocucci has imported this pull request. If you are a Meta employee, you can view this in D92964613.

[meta-codesync]

@fabriziocucci merged this pull request in 3fb5c0b.

[react-native-bot]

This pull request was successfully merged by @hannojg in 3fb5c0b

^{When will my fix make it into a release? | How to file a pick request?}