Fix MissingSoLoaderLibrary: Add @SoLoaderLibrary to BlobCollector #55514
+39
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
mdvacca
force-pushed
the
export-D92024489
branch
from
6e36120 to
fd587d5
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Feb 11, 2026
…cebook#55514) Summary: Fixed MissingSoLoaderLibrary lint error in BlobCollector.kt. Added `SoLoaderLibrary("reactnativeblob")` annotation to document that this class loads the "reactnativeblob" native library via SoLoader. Also added the required soloader annotation dependency to the BUCK file. changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D92024489
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Feb 11, 2026
…cebook#55514) Summary: Pull Request resolved: facebook#55514 Fixed MissingSoLoaderLibrary lint error in BlobCollector.kt. Added `SoLoaderLibrary("reactnativeblob")` annotation to document that this class loads the "reactnativeblob" native library via SoLoader. Also added the required soloader annotation dependency to the BUCK file. changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D92024489
mdvacca
force-pushed
the
export-D92024489
branch
from
fd587d5 to
781d680
Compare
Summary: The BaseVMFocusChangeListener inner class does not reference any members of its outer class BaseViewManager. Making it static improves memory efficiency by avoiding the implicit reference to the outer class instance. Also removed the unused type parameter <V extends View> and changed the method parameters from T to View since only View interface methods are used. Reviewed By: cortinico Differential Revision: D92020879
Summary: This change adds missing Override annotations to three methods in LayoutShadowNode that override methods from the parent class: - setFlex(float) - setFlexGrow(float) - setFlexShrink(float) These methods call super.setFlex/setFlexGrow/setFlexShrink, indicating they override parent methods and should have Override annotations for code clarity and compiler checking. Reviewed By: alanleedev Differential Revision: D92021000
Summary: Remove unused code that was triggering lint warnings: 1. Remove `walkUpUntilNativeKindIsParent` private method that was never invoked 2. Remove `parent` variable in `applyLayoutBase` that was never accessed Both were leftover from NativeKind removal. Reviewed By: alanleedev Differential Revision: D92021031
Summary:
Replace `TextUtils.join(", ", features)` with the idiomatic Kotlin
`features.joinToString(", ")`. This fixes the HasBetterKotlinAlternativeMethod
lint warning and removes the now-unused TextUtils import.
Reviewed By: alanleedev
Differential Revision: D92021387
…AttributeProps
Summary: Replace `TextUtils.join(", ", features)` with Kotlin's idiomatic `features.joinToString(", ")` to fix the HasBetterKotlinAlternativeMethod lint warning. Also removed the now-unused `TextUtils` import while keeping the `TextUtils.TruncateAt` import that is still in use.
Reviewed By: alanleedev
Differential Revision: D92021465
Summary:
Add the SoLoaderLibrary("jsijniprofiler") annotation to HermesSamplingProfiler
to fix the MissingSoLoaderLibrary androidlint warning. This annotation helps
track which native libraries are loaded by this class, improving build and
startup optimization analysis.
Also added the required dependency on soloader annotation library in the BUCK file.
Reviewed By: alanleedev
Differential Revision: D92022030
Summary: Replace TargetApi(29) with RequiresApi(29) in BlendModeHelper.kt to fix the UseRequiresApi lint warning. The RequiresApi annotation from AndroidX properly propagates the API level requirement to callers, while TargetApi only suppresses the lint warning locally without providing this safety. Also updated the import from android.annotation.TargetApi to androidx.annotation.RequiresApi. Reviewed By: alanleedev Differential Revision: D92022472
…ostInspectorTarget
Summary:
This fixes the MissingSoLoaderLibrary lint warning in ReactHostInspectorTarget.kt by
adding the SoLoaderLibrary("rninstance") annotation to the companion object that
loads the native library via SoLoader.loadLibrary(). This annotation helps with static
analysis and proper tracking of native library dependencies.
Also adds the required soloader annotation dependency to the BUCK file.
Reviewed By: alanleedev
Differential Revision: D92022954
Summary:
Fixed MissingSoLoaderLibrary lint error in JSRuntimeFactory.kt.
Added `SoLoaderLibrary("rninstance")` annotation to document that this class loads
the "rninstance" native library via SoLoader.
changelog: [internal] internal
Reviewed By: alanleedev
Differential Revision: D92023701
Summary:
Fixed MissingSoLoaderLibrary lint error in JSTimerExecutor.kt.
Added `SoLoaderLibrary("rninstance")` annotation to document that this class loads
the "rninstance" native library via SoLoader.
changelog: [internal] internal
Reviewed By: alanleedev
Differential Revision: D92023704
Summary:
Fixed MissingSoLoaderLibrary lint error in HermesInstance.kt.
Added `SoLoaderLibrary("hermesinstancejni")` annotation to document that this class
loads the "hermesinstancejni" native library via SoLoader.
Also added the required soloader annotation dependency to the BUCK file.
changelog: [internal] internal
Reviewed By: alanleedev
Differential Revision: D92023711
Summary: Fixed NoHungarianNotation lint error in CxxInspectorPackagerConnection.kt. Renamed `mHybridData` to `hybridData` to follow Kotlin naming conventions. Hungarian Notation (m prefix for member variables) should be avoided in Kotlin as it does not play well with Java interoperability. changelog: [internal] internal Differential Revision: D92023753
…lverBinding (facebook#55512) Summary: Fixed MissingSoLoaderLibrary lint error in ComponentNameResolverBinding.kt. Added `SoLoaderLibrary("uimanagerjni")` annotation to document that this class loads the "uimanagerjni" native library via SoLoader. Also added the required soloader annotation dependency to the BUCK file. changelog: [internal] internal Reviewed By: NickGerleman, alanleedev Differential Revision: D92024027
…cebook#55513) Summary: Fixed FieldsBelowInit lint warning in SurfaceHandlerBinding.kt. Moved the property declarations (surfaceId, isRunning, moduleName) before the init block to follow Kotlin best practices for initialization order. Note: These are computed properties (getters) that call native methods, so the warning was technically a false positive, but reordering improves code clarity. changelog: [internal] internal Reviewed By: alanleedev, NickGerleman Differential Revision: D92024128
…cebook#55514) Summary: Fixed MissingSoLoaderLibrary lint error in BlobCollector.kt. Added `SoLoaderLibrary("reactnativeblob")` annotation to document that this class loads the "reactnativeblob" native library via SoLoader. Also added the required soloader annotation dependency to the BUCK file. changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D92024489
mdvacca
force-pushed
the
export-D92024489
branch
from
781d680 to
2227b54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixed MissingSoLoaderLibrary lint error in BlobCollector.kt.
Added
SoLoaderLibrary("reactnativeblob")annotation to document that this classloads the "reactnativeblob" native library via SoLoader.
Also added the required soloader annotation dependency to the BUCK file.
changelog: [internal] internal
Reviewed By: alanleedev
Differential Revision: D92024489