Extract shared GlobalStateObserver from FuseboxSessionObserver #55485
+247
−137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@emily8rown has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92720212. |
emily8rown
added a commit
to emily8rown/react-native
that referenced
this pull request
Feb 10, 2026
…ook#55485) Summary: The FuseboxSessionObserver pattern (a native global object with boolean state, subscribers Set, and state change callback) is going to be reused for PerformanceTracerObserver in D92527815. This diff extracts the shared logic into reusable components: JS: GlobalStateObserver class parameterized by global name and status property. C++: installGlobalStateObserver() and emitGlobalStateObserverChange() functions parameterized by global name, status property, and callback name. FuseboxSessionObserver and RuntimeTargetDebuggerSessionObserver now delegate to the shared implementations. No behavior change. Reviewed By: hoxyq Differential Revision: D92720212
emily8rown
force-pushed
the
export-D92720212
branch
from
d727332 to
2183c63
Compare
emily8rown
added a commit
to emily8rown/react-native
that referenced
this pull request
Feb 11, 2026
…ook#55485) Summary: The FuseboxSessionObserver pattern (a native global object with boolean state, subscribers Set, and state change callback) is going to be reused for PerformanceTracerObserver in D92527815. This diff extracts the shared logic into reusable components: JS: GlobalStateObserver class parameterized by global name and status property. C++: installGlobalStateObserver() and emitGlobalStateObserverChange() functions parameterized by global name, status property, and callback name. FuseboxSessionObserver and RuntimeTargetDebuggerSessionObserver now delegate to the shared implementations. No behavior change. Changelog: [GENERAL] [CHANGED] - extracting shared logic for fuseboxSessionObserver into reusable components Reviewed By: hoxyq Differential Revision: D92720212
emily8rown
added a commit
to emily8rown/react-native
that referenced
this pull request
Feb 11, 2026
…ook#55485) Summary: The FuseboxSessionObserver pattern (a native global object with boolean state, subscribers Set, and state change callback) is going to be reused for PerformanceTracerObserver in D92527815. This diff extracts the shared logic into reusable components: JS: GlobalStateObserver class parameterized by global name and status property. C++: installGlobalStateObserver() and emitGlobalStateObserverChange() functions parameterized by global name, status property, and callback name. FuseboxSessionObserver and RuntimeTargetDebuggerSessionObserver now delegate to the shared implementations. No behavior change. Changelog: [GENERAL] [CHANGED] - extracting shared logic for fuseboxSessionObserver into reusable components Reviewed By: hoxyq Differential Revision: D92720212
…ook#55485) Summary: The FuseboxSessionObserver pattern (a native global object with boolean state, subscribers Set, and state change callback) is going to be reused for PerformanceTracerObserver in D92527815. This diff extracts the shared logic into reusable components: JS: GlobalStateObserver class parameterized by global name and status property. C++: installGlobalStateObserver() and emitGlobalStateObserverChange() functions parameterized by global name, status property, and callback name. FuseboxSessionObserver and RuntimeTargetDebuggerSessionObserver now delegate to the shared implementations. No behavior change. Changelog: [GENERAL] [CHANGED] - extracting shared logic for fuseboxSessionObserver into reusable components Reviewed By: hoxyq Differential Revision: D92720212
emily8rown
force-pushed
the
export-D92720212
branch
from
2183c63 to
520bc36
Compare
|
This pull request has been merged in b0013ea. |
Collaborator
|
This pull request was successfully merged by @emily8rown in b0013ea When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The FuseboxSessionObserver pattern (a native global object with boolean state, subscribers Set, and state change callback) is going to be reused for PerformanceTracerObserver in D92527815. This diff extracts the shared logic into reusable components:
JS: GlobalStateObserver class parameterized by global name and status property.
C++: installGlobalStateObserver() and emitGlobalStateObserverChange() functions parameterized by global name, status property, and callback name.
FuseboxSessionObserver and RuntimeTargetDebuggerSessionObserver now delegate to the shared implementations. No behavior change.
Differential Revision: D92720212