Skip to content

fix(iOS): Add null check for fontName in RCTGetFontWeight to prevent crash #55414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
25harsh wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(iOS): Add null check for fontName in RCTGetFontWeight to prevent crash #55414

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b6d069
fix(iOS): Add null check for fontName in RCTGetFontWeight to prevent …
25harsh Feb 5, 2026
2198915
fix(iOS): Add nil check for font parameter
25harsh Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions packages/react-native/React/Views/RCTFont.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@

RCTFontWeight RCTGetFontWeight(UIFont *font)
{
if (!font) {
return UIFontWeightRegular;
}

static NSArray<NSString *> *weightSuffixes;
static NSArray<NSNumber *> *fontWeights;
static dispatch_once_t onceToken;
Expand Down Expand Up @@ -54,14 +58,16 @@ RCTFontWeight RCTGetFontWeight(UIFont *font)
});

NSString *fontName = font.fontName;
NSInteger i = 0;
for (NSString *suffix in weightSuffixes) {
// CFStringFind is much faster than any variant of rangeOfString: because it does not use a locale.
auto options = kCFCompareCaseInsensitive | kCFCompareAnchored | kCFCompareBackwards;
if (CFStringFind((CFStringRef)fontName, (CFStringRef)suffix, options).location != kCFNotFound) {
return (RCTFontWeight)fontWeights[i].doubleValue;
if (fontName) {
NSInteger i = 0;
for (NSString *suffix in weightSuffixes) {
// CFStringFind is much faster than any variant of rangeOfString: because it does not use a locale.
auto options = kCFCompareCaseInsensitive | kCFCompareAnchored | kCFCompareBackwards;
if (CFStringFind((CFStringRef)fontName, (CFStringRef)suffix, options).location != kCFNotFound) {
return (RCTFontWeight)fontWeights[i].doubleValue;
}
i++;
}
i++;
}

auto traits = (__bridge_transfer NSDictionary *)CTFontCopyTraits((CTFontRef)font);
Expand Down
Loading