Skip to content

Remove const qualifier from side-effectful methods of Agents and Targets #55314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
motiz88 wants to merge 1 commit into from
+12 −14
Closed

Remove const qualifier from side-effectful methods of Agents and Targets #55314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/react-native/ReactCommon/jsinspector-modern/HostAgent.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,8 +385,7 @@ class HostAgent::Impl final {
return fuseboxClientType_ == FuseboxClientType::Fusebox;
}

void emitExternalTracingProfile(
tracing::HostTracingProfile tracingProfile) const {
void emitExternalTracingProfile(tracing::HostTracingProfile tracingProfile) {
assert(
hasFuseboxClientConnected() &&
"Attempted to emit a trace recording to a non-Fusebox client");
Expand Down Expand Up @@ -543,11 +542,11 @@ bool HostAgent::hasFuseboxClientConnected() const {
}

void HostAgent::emitExternalTracingProfile(
tracing::HostTracingProfile tracingProfile) const {
tracing::HostTracingProfile tracingProfile) {
impl_->emitExternalTracingProfile(std::move(tracingProfile));
}

void HostAgent::emitSystemStateChanged(bool isSingleHost) const {
void HostAgent::emitSystemStateChanged(bool isSingleHost) {
impl_->emitSystemStateChanged(isSingleHost);
}

Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/ReactCommon/jsinspector-modern/HostAgent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,13 @@ class HostAgent final {
* Emits the HostTracingProfile that was captured externally, not via the
* CDP-initiated request.
*/
void emitExternalTracingProfile(tracing::HostTracingProfile tracingProfile) const;
void emitExternalTracingProfile(tracing::HostTracingProfile tracingProfile);

/**
* Emits a system state changed event when the number of ReactHost instances
* changes.
*/
void emitSystemStateChanged(bool isSingleHost) const;
void emitSystemStateChanged(bool isSingleHost);

private:
// We use the private implementation idiom to ensure this class has the same
Expand Down
5 changes: 2 additions & 3 deletions packages/react-native/ReactCommon/jsinspector-modern/HostTarget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,7 @@ class HostTargetSession {
return hostAgent_.hasFuseboxClientConnected();
}

void emitHostTracingProfile(
tracing::HostTracingProfile tracingProfile) const {
void emitHostTracingProfile(tracing::HostTracingProfile tracingProfile) {
hostAgent_.emitExternalTracingProfile(std::move(tracingProfile));
}

Expand Down Expand Up @@ -384,7 +383,7 @@ bool HostTarget::hasActiveSessionWithFuseboxClient() const {
}

void HostTarget::emitTracingProfileForFirstFuseboxClient(
tracing::HostTracingProfile tracingProfile) const {
tracing::HostTracingProfile tracingProfile) {
bool emitted = false;
sessions_.forEach([&](HostTargetSession& session) {
if (emitted) {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/jsinspector-modern/HostTarget.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ class JSINSPECTOR_EXPORT HostTarget : public EnableExecutorFromThis<HostTarget>
*
* @see \c hasActiveFrontendSession
*/
void emitTracingProfileForFirstFuseboxClient(tracing::HostTracingProfile tracingProfile) const;
void emitTracingProfileForFirstFuseboxClient(tracing::HostTracingProfile tracingProfile);

/**
* An endpoint for the Host to report frame timings that will be recorded if and only if there is currently an active
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/ReactCommon/jsinspector-modern/TracingAgent.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,14 +120,14 @@ bool TracingAgent::handleRequest(const cdp::PreparsedRequest& req) {
}

void TracingAgent::emitExternalHostTracingProfile(
tracing::HostTracingProfile tracingProfile) const {
tracing::HostTracingProfile tracingProfile) {
frontendChannel_(
cdp::jsonNotification("ReactNativeApplication.traceRequested"));
emitHostTracingProfile(std::move(tracingProfile));
}

void TracingAgent::emitHostTracingProfile(
tracing::HostTracingProfile tracingProfile) const {
tracing::HostTracingProfile tracingProfile) {
auto dataCollectedCallback = [this](folly::dynamic&& eventsChunk) {
frontendChannel_(
cdp::jsonNotification(
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/ReactCommon/jsinspector-modern/TracingAgent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class TracingAgent {
/**
* Emits the HostTracingProfile that was stashed externally by the HostTarget.
*/
void emitExternalHostTracingProfile(tracing::HostTracingProfile tracingProfile) const;
void emitExternalHostTracingProfile(tracing::HostTracingProfile tracingProfile);

private:
/**
Expand All @@ -60,7 +60,7 @@ class TracingAgent {
* Emits captured HostTracingProfile in a series of
* Tracing.dataCollected events, followed by a Tracing.tracingComplete event.
*/
void emitHostTracingProfile(tracing::HostTracingProfile tracingProfile) const;
void emitHostTracingProfile(tracing::HostTracingProfile tracingProfile);
};

} // namespace facebook::react::jsinspector_modern
Loading