WeakList: add anyOf + const-propagating forEach #55313
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Changelog: [Internal] TSIA Reviewed By: hoxyq Differential Revision: D90998980
…ebook#55240) Summary: Changelog: [General][Fixed] Send network events to all CDP clients with the Network domain enabled Reviewed By: hoxyq Differential Revision: D90888854
…ns) (facebook#55287) Summary: Changelog: [Internal] Adds tests (and a doc comment) codifying the existing, correct behavior of the CDP `Tracing.start` command when there is already a tracing session in progress. Reviewed By: hoxyq Differential Revision: D90888857
Summary: TSIA - minor refactor for correctness and clarity before making changes to some of these methods up the stack. Changelog: [Internal] Reviewed By: hoxyq Differential Revision: D91140491
Summary: Changelog: [Internal] TSIA - minor refactor for convenience and correctness. NOTE: When we get C++23, we can deduplicate the identical const/non-const method bodies using the nifty [deducing `this`](https://en.cppreference.com/w/cpp/language/member_functions.html#Explicit_object_member_functions) feature. Reviewed By: hoxyq Differential Revision: D91140490
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
TSIA - minor refactor for convenience and correctness.
NOTE: When we get C++23, we can deduplicate the identical const/non-const method bodies using the nifty deducing
thisfeature.Reviewed By: hoxyq
Differential Revision: D91140490