fix(hermes-inspector-modern): Apply HERMES_V1_ENABLED define to all build types #55312
+3
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uild types The HERMES_V1_ENABLED compile option was incorrectly scoped inside the else() block, meaning it only applied to Release builds. This caused Debug builds to fail with missing header errors: fatal error: 'hermes/inspector/RuntimeAdapter.h' file not found Move the HERMES_V1_ENABLED conditional outside the Debug/Release if-else block so the define is applied regardless of build type. Note: target_compile_options() is additive in CMake, so this correctly appends to existing options rather than overriding them.
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D91581367. |
Moved the HERMES_V1_ENABLED compile definition into the centralized target_compile_reactnative_options function in react-native-flags.cmake, eliminating duplicate conditional blocks across 7 CMakeLists.txt files. This ensures the define is consistently applied to all targets that use target_compile_reactnative_options when HERMES_V1_ENABLED is set, and makes the codebase easier to maintain. Files cleaned up: - ReactCommon/cmake-utils/react-native-flags.cmake (added centralized logic) - ReactCommon/hermes/inspector-modern/CMakeLists.txt - ReactCommon/hermes/executor/CMakeLists.txt - ReactCommon/react/runtime/CMakeLists.txt - ReactCommon/react/runtime/hermes/CMakeLists.txt - ReactAndroid/.../hermes/reactexecutor/CMakeLists.txt - ReactAndroid/.../runtime/hermes/jni/CMakeLists.txt - ReactAndroid/.../runtime/jni/CMakeLists.txt
cortinico
reviewed
Jan 27, 2026
packages/react-native/ReactCommon/cmake-utils/react-native-flags.cmake
Outdated
Show resolved
Hide resolved
Job Summary for GradleTest All :: run_fantom_tests
|
|
@cortinico merged this pull request in 8d68b11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The HERMES_V1_ENABLED compile option was incorrectly scoped inside the else() block, meaning it only applied to Release builds. This caused Debug builds to fail with missing header errors:
fatal error: 'hermes/inspector/RuntimeAdapter.h' file not found
This happens when Expo builds Hermes in release mode but WITH the debugger enabled.
Moved the HERMES_V1_ENABLED compile definition into the centralized target_compile_reactnative_options function in react-native-flags.cmake, eliminating duplicate conditional blocks across 7 CMakeLists.txt files.
This ensures the define is consistently applied to all targets that use
target_compile_reactnative_options when HERMES_V1_ENABLED is set, and makes the codebase easier to maintain.
Files cleaned up:
Changelog:
[ANDROID] [FIXED] - Fixed so that all build types get the HERMES_V1_ENABLED flag
Test Plan:
Build RN Tester with HERMES_V1