fix: stale RCTModalHostViewController blocks touch inputs #54858
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Resolves #54856
Fixes a but when
RCTModalHostViewControllertries to dismiss itself using the following code:But since it's already presenting another VC on top of it (e.g., login web view VC, photo picker VC, etc), it dismisses that view but not itself, which results in a transparent modal VC (all the UI is unmounted) that is the top VC blocking all touch input.
The change is minimal: instead of calling
dismissViewControllerAnimated:completion:onmodalViewController, which has two different behaviors depending on whether that VC is presenting another VC, it calls it onmodalViewController.presentingViewController, which has a unique behavior of dismissingmodalViewController.Changelog:
Test Plan: