add build system integration tests#3628
Open
kinto0 wants to merge 2 commits into
Open
Conversation
…acebook#3627) Summary: External users with custom build systems (e.g., Arista Networks) need the build system to be the single source of truth for both import resolution and type checking settings. Currently the build system JSON response can provide `srcs` and `deps` per target, but has no way to communicate per-target type checking configuration or per-target source roots. This adds two new optional fields to `PythonLibraryManifest`: - `config`: raw JSON config overrides (errors, preset, etc.) that are deserialized into `ConfigBase` by `pyrefly_config` at resolution time. Stored as `serde_json::Value` to avoid a circular crate dependency. - `root`: per-target override of the top-level root, used for both absolutizing `srcs` paths and as the import resolution root. Also makes `deps` and `buildfile_path` optional via `#[serde(default)]` so build systems that don't map cleanly to per-target deps can omit them. The config resolution chain becomes: sub-config -> target config -> root config -> preset defaults `ErrorConfig` is simplified to own its `ErrorDisplayConfig` (removing the lifetime parameter) so that target configs deserialized from JSON can participate in the resolution chain without lifetime issues. Differential Revision: D107113346
Differential Revision: D107130002
Contributor
|
@kinto0 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107130002. |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: D107130002