public symbol filtering with pyrefly report --public-only #3104#3162
Open
jorenham wants to merge 2 commits intofacebook:mainfrom
Open
public symbol filtering with pyrefly report --public-only #3104#3162jorenham wants to merge 2 commits intofacebook:mainfrom
pyrefly report --public-only #3104#3162jorenham wants to merge 2 commits intofacebook:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
|
Hey @stroxler, are you familiar with Pyrefly report? Would you be able to take a look at this? |
1 similar comment
Contributor
|
Hey @stroxler, are you familiar with Pyrefly report? Would you be able to take a look at this? |
This comment has been minimized.
This comment has been minimized.
Contributor
|
@migeed-z has imported this pull request. If you are a Meta employee, you can view this in D101673000. |
connernilsen
requested changes
Apr 20, 2026
Contributor
connernilsen
left a comment
connernilsen
left a comment
There was a problem hiding this comment.
Hey @jorenham, thanks for doing this! I have a few recommendations, but can you rebase and re-request review once you're ready again?
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In #3104 I proposed that
pyrefly reportalso includes an export graph so we'd be able to figure out intypestatswhat the public symbols are as post-processing step.With this change, that is no longer needed. Because now,
pyrefly report --public-onlywill report only the public symbols, using the cross-module tracing algorithm from typestats.Right now this is opt-in. But we could also make this the default, and instead add a
--include-privateflag or something. Thoughts?Fixes #3104
Test Plan
Tests added