Fix support for inmemory files in did_open#3137
Closed
austin3dickey wants to merge 1 commit intofacebook:mainfrom
Closed
Fix support for inmemory files in did_open#3137austin3dickey wants to merge 1 commit intofacebook:mainfrom
did_open#3137austin3dickey wants to merge 1 commit intofacebook:mainfrom
Conversation
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Contributor
|
@rchen152 has imported this pull request. If you are a Meta employee, you can view this in D100894098. |
kinto0
approved these changes
Apr 15, 2026
Contributor
kinto0
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't make an issue for this, but I can first if you'd like!
Summary
One-line change to fix
inmemorydocuments (e.g. the Positron Console) failing to be registered with the server on Windows.This is a follow-up to #1637, which added
inmemoryto the extension'sdocumentSelector. That change works on Mac/Linux but not on Windows because the LSP server'sdid_openrejectsinmemoryURIs on that platform.Root cause
When
did_openreceives aninmemoryURI likeinmemory:/repl-python-<uuid>, it callsUrl::to_file_path(). That method doesn't check the URI scheme, it just converts path segments into a platform path. On Mac/Linux this happens to succeed (producing/repl-python-<uuid>), but on Windows it fails becausefile_url_segments_to_pathbuf_windowsrequires the first path segment to be a drive letter likeC:.After
to_file_path()fails, the fallback indid_openonly acceptsuntitled, soinmemorydocuments are silently rejected on Windows and never registered. But the fallback should work for both schemes.Fix
Extend the scheme check in
did_opento also acceptinmemory, routing it through theUnsavedFileTracker. This makes the behavior consistent across platforms instead of relying onto_file_path()accidentally succeeding on Unix.I added tests for semantic tokens and completions on
inmemorydocuments, mirroring the existinguntitledtests, so regressions here will be caught going forward.Test Plan
unsaved_filetests still passtest.py(no changes)