support non-standard "self" and "cls" param names in pyrefly report #3095#3126
Closed
jorenham wants to merge 1 commit intofacebook:mainfrom
Closed
support non-standard "self" and "cls" param names in pyrefly report #3095#3126jorenham wants to merge 1 commit intofacebook:mainfrom
pyrefly report #3095#3126jorenham wants to merge 1 commit intofacebook:mainfrom
Conversation
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Contributor
|
@rchen152 has imported this pull request. If you are a Meta employee, you can view this in D100901334. |
stroxler
approved these changes
Apr 15, 2026
Contributor
stroxler
left a comment
stroxler
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds support for detecting instance/class-bound method (first) parameters that aren't named
selforcls. It will, for example, now correctly count__new__(_cls) -> Selfas annotated.Fixes #3095
Test Plan
Added unit tests and integration tests