strip "-stubs" suffix from FQN in pyrefly report #3094#3125
Closed
jorenham wants to merge 1 commit intofacebook:mainfrom
Closed
strip "-stubs" suffix from FQN in pyrefly report #3094#3125jorenham wants to merge 1 commit intofacebook:mainfrom
pyrefly report #3094#3125jorenham wants to merge 1 commit intofacebook:mainfrom
Conversation
Contributor
|
Thanks for all the pyrefly report fixes, @jorenham! |
Contributor
|
@rchen152 has imported this pull request. If you are a Meta employee, you can view this in D100900648. |
Contributor
Author
|
I see there's a warning, but not what it is exactly 🤔 |
stroxler
approved these changes
Apr 15, 2026
Contributor
stroxler
left a comment
stroxler
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Contributor
Oh, you can ignore the signal from "Facebook Internal". I sort of wish we didn't export that, but I don't think we can hide it XD (In this case, the warning is just for a pre-existing skipped test.) |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the fully-qualified names reported with
pyrefly reportfor stubs-only packages according to PEP 561 by removing the top-level-stubssuffix.Fixes #3094
Test Plan
added a unit test