Added sb instruction support for ARMv9 architecture#66
Open
salvatoredipietro wants to merge 1 commit intofacebook:devfrom
Open
Added sb instruction support for ARMv9 architecture#66salvatoredipietro wants to merge 1 commit intofacebook:devfrom
salvatoredipietro wants to merge 1 commit intofacebook:devfrom
Conversation
|
Thanks for the PR! Do you have any thoughts on the use of a higher-throughput instruction for a delay loop? Intuitively, you need to waste some time so the difference between an As an aside, the approach suggested by ARM involves uses a more precise delay loop to account for the differences. That might require a slightly bigger change to the |
Author
|
Reducing the waiting time, give more possibility to spinlock to succeed faster. Using lockhammer (a locking/contention benchmark) we see a improvement of 11-18%. Also Folly project (facebook/folly#2390) saw a good perf bump ( between 20% and 30% with >=16 threads). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We would like to add the support for ARMv9 architecture to use sb instruction instead of isb.
Based on our micro benchmark (patch attached), sb is ~30% faster than isb (ratio=1.710:1) and the change do not seems to introduce any regression on the spin_cpu_spinwait() function (isb_spin=8740725us vs standard_spin=8739722us).
Original post: jemalloc#2843