Skip to content

Missing appsecret proof fixes #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aramupwork wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Missing appsecret proof fixes #593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a99c9f6
Added appsecret_proof parameter to video_uploader.py
aramupwork Apr 30, 2021
4017ef3
Added appsecret_proof parameter to advideo.py
aramupwork Apr 30, 2021
26e2164
Merge branch 'main' into missing-appsecret_proof-fixes
aramupwork Dec 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion facebook_business/adobjects/advideo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1337,7 +1337,7 @@ def remote_create(
self._set_data(response)
return response

def waitUntilEncodingReady(self, interval=30, timeout=600):
def waitUntilEncodingReady(self, interval=30, timeout=600, appsecret_proof=None):
from facebook_business.video_uploader import VideoEncodingStatusChecker
from facebook_business.exceptions import FacebookError

Expand All @@ -1350,4 +1350,5 @@ def waitUntilEncodingReady(self, interval=30, timeout=600):
self['id'],
interval,
timeout,
appsecret_proof,
)
11 changes: 7 additions & 4 deletions facebook_business/video_uploader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,10 +371,10 @@ def setParams(self, params, files=None):
class VideoEncodingStatusChecker(object):

@staticmethod
def waitUntilReady(api, video_id, interval, timeout):
def waitUntilReady(api, video_id, interval, timeout, appsecret_proof):
start_time = time.time()
while True:
status = VideoEncodingStatusChecker.getStatus(api, video_id)
status = VideoEncodingStatusChecker.getStatus(api, video_id, appsecret_proof)
status = status['video_status']
if status != 'processing':
break
Expand All @@ -388,10 +388,13 @@ def waitUntilReady(api, video_id, interval, timeout):
return

@staticmethod
def getStatus(api, video_id):
def getStatus(api, video_id, appsecret_proof):
params={'fields': 'status'}
if appsecret_proof is not None:
params['appsecret_proof'] = appsecret_proof
result = api.call(
'GET',
[int(video_id)],
params={'fields': 'status'},
params=params,
).json()
return result['status']