Remove bespoke orchestor generation logic#4998
Open
mgarrard wants to merge 1 commit intofacebook:mainfrom
Open
Remove bespoke orchestor generation logic#4998mgarrard wants to merge 1 commit intofacebook:mainfrom
mgarrard wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: TLDR -- Added stagedtrialspausingcriterion, missingoptimizationconfigpauscriterion. Renamed count_only_trials_with_data to count_only_trials_without_data for pausing criterion to more accurately reflect usage. Updated some generation strategies to leverage the new criterions. Validated storage. Differential Revision: D92867234
meta-cla
Bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4998 +/- ##
========================================
Coverage 96.84% 96.84%
========================================
Files 601 601
Lines 64732 64872 +140
========================================
+ Hits 62690 62827 +137
- Misses 2042 2045 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: TLDR -- Added stagedtrialspausingcriterion, missingoptimizationconfigpauscriterion. Renamed count_only_trials_with_data to count_only_trials_without_data for pausing criterion to more accurately reflect usage. Updated some generation strategies to leverage the new criterions. Validated storage.
Differential Revision: D92867234