Revert "[prism] Match Ripper's multilining logic for call chains beginning with literal expressions" #770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nning wi…" This reverts commit 1588924.
froydnj
approved these changes
Jan 7, 2026
Collaborator
froydnj
left a comment
froydnj
left a comment
There was a problem hiding this comment.
This is fine by me. I wish we had more testcases around this stuff.
idk if you have a post-prism checklist, but perhaps this testcase, slightly altered, would be a good candidate for committing after ripper disappears.
Collaborator
Author
|
We can just leave it around as a Prism-specific test if that's worthwhile, I can revert the old change but leave parser-specific outputs |
Collaborator
Author
|
(Actually I'll do this in a separate PR, I'm gonna try and make a few test cases for this and try to dial in where they differ) |
Collaborator
|
Oh, that's right, I forgot about the denylists for tests. That'd be great! |
This was referenced Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #766