Draft
Conversation
Owner
|
Very cool! However, as much as I would love to see everybody using zod to validate their API response, I think this feature should be opt-in. I actually used to have this setup in production, and to avoid any runtime cost, this feature was enabled only in dev & qa. |
1a26474 to
2f33022
Compare
Author
|
I've added a responseValidatorEnabled flag between the fetcherOptions to programmatically enable the responseValidator to be executed. |
|
+1 This would be very useful for react hook form + zod resolver! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request attempts to address the issue #148.
I haven't added the tests yet and I haven't found if there are any guidelines on the quality of contributions.
However, I would kindly like a review to see if I am on the right track.
thank you.