fix: type checking errors in tools directory#217
Closed
ezyang wants to merge 1 commit intogh/ezyang/166/basefrom
Closed
fix: type checking errors in tools directory#217ezyang wants to merge 1 commit intogh/ezyang/166/basefrom
ezyang wants to merge 1 commit intogh/ezyang/166/basefrom
Conversation
ezyang
added a commit
that referenced
this pull request
Mar 25, 2025
Typecheck and fix all errors in codemcp/tools/ ```git-revs 79b88dc (Base revision) 950c78a Add AsyncAbortSignal protocol for type checking 2bf74a9 Import AsyncAbortSignal in chmod.py fc9a1a3 Add AsyncAbortSignal type annotation to chmod function 21d64ee Ensure chat_id is not None when calling commit_changes b472620 Import AsyncAbortSignal in git_blame.py 9350d33 Add AsyncAbortSignal type annotation to git_blame function e712304 Remove codemcp/signal_types.py: Remove unnecessary signal_types.py dff8f2a Remove unnecessary AsyncAbortSignal import in chmod.py 86c5519 Change signal parameter type to Any in chmod.py 21c0a41 Remove unnecessary AsyncAbortSignal import in git_blame.py af0ea51 Change signal parameter type to Any in git_blame.py a7aa14f Add proper type annotation for signal parameter in git_diff.py 21ddade Add proper type annotation for signal parameter in git_log.py beb86ab Remove unused signal parameter from git_show.py 5862d82 Remove unused signal parameter from git_blame.py 9e37110 Remove unused signal parameter from git_diff.py 6d3d32a Remove unused signal parameter from git_log.py 38d525f Remove unused signal parameter from chmod.py f11bd7a Remove signal parameter from chmod.py docstring 758b714 Remove signal parameter from git_blame.py docstring 9580448 Remove signal parameter from git_diff.py docstring 5185135 Remove signal parameter from git_log.py docstring d07756a Remove signal parameter from git_show.py docstring 56af8e6 Remove unused signal parameter from glob.py d0c0a3e Remove signal parameter from glob.py docstring acc9507 Remove unused signal parameter from glob_files function be65e0e Remove signal parameter from glob_files docstring a08963b Remove unused signal parameter from git_grep function f98cc86 Remove signal parameter from git_grep docstring 793a395 Remove unused signal parameter from grep_files function d80863a Remove signal parameter from grep_files docstring 1286918 Update git_grep call to remove signal parameter 17d29cf Fix split() in grep.py to correctly split string 7be44fd Initialize best_match_i to fix possible unbound variable error 38320cd Initialize best_match with empty list to avoid None checks def9944 Add check for empty search_lines or content_lines a08d108 Add proper type annotation for dict in apply_edit return type 5232434 Add Any to imports in edit_file.py a3a5f83 Fix zip function call in try_dotdotdots to handle type checking correctly 35fd1cf Fix default value for chat_id to use empty string instead of None 28acdaa Fix default value for chat_id to use empty string instead of None c351e11 Fix default value for chat_id to use empty string instead of None 8739877 Add required type imports in init_project.py 3006ef7 Add proper type annotation for command_docs parameter 3b1f3fa Fix description parameter type in _generate_chat_id function f6ef39c Fix unused variables in init_project.py by using _ to discard returned values 1096afc Remove unused Optional import 56b2265 Remove unused Any import 614362e Fix unused variable 'patch' in edit_file.py by using _ to discard returned value 8f27a3d Fix glob function call to remove signal parameter 09a56ce Handle None case for command_list in run_command.py HEAD Update run_code_command call to use actual_command ``` codemcp-id: 227-fix-type-checking-errors-in-tools-directory ghstack-source-id: f43e837 Pull-Request-resolved: #217
This was referenced Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Typecheck and fix all errors in codemcp/tools/
codemcp-id: 227-fix-type-checking-errors-in-tools-directory