Added support for caching REST api calls to POST /api/ezp/v2/views#147
Draft
Added support for caching REST api calls to POST /api/ezp/v2/views#147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a change to the varnish .vcl that makes it possible to cache POST requests to
/api/ezp/v2/views(which is basically a search ).The
/api/ezp/v2/viewsendpoint do not providexkeyheader in the response so purging won't work, thus the TTL is set to 600 by default.Don't think we should merge this as-is (
/api/ezp/v2/viewsshould defently providexkeyheaders first ). But posting the code here for reference. It might be valuable to others too.Credits to @reithor and @adriendupuis who also worked on this code
TODO:
$ composer test)$ composer fix-cs).